spicypete
Joined 3 years ago
Karma
152
Submissions
18
Member since
Nov 16
Recent submissions
Comment · 4 months ago
Great, refreshing read and a welcome break from the AI slopalypse.
Comment · 1 year ago
(from a companies perspective, this is true). As a developer, you may not be paid by the task -- If I finish something early, I start work on the next thing.
Comment · 1 year ago
In the spirit of constructive feedback, I filed an issue for you: https://github.com/reteps/dockerfmt/issues/18
I fixed this in the 0.2.8 release https://github.com/reteps/dockerfmt/releases/tag/0.2.8.
Relevant reading about the `&&` normalization. https://pkg.go.dev/encoding/json#Marshal
Comment · 1 year ago
Then they can use one of the 14 in the `tests` directory :) https://github.com/reteps/dockerfmt/tree/main/tests
Comment · 1 year ago
What I can do for you is fix the bugs promptly! I resolved the bugs in the `0.2.7` release. I haven't graduated college yet and don't have a full time job, so my QA skills are still improving.
Comment · 1 year ago
This is a valid point -- I replied to why this is the way it is here: https://news.ycombinator.com/item?id=43629049. I understand it's not ideal for many, and I am open to PRs!
Comment · 1 year ago
I am certainly not in the business of writing my own shell parser ;) Though this is a fair point -- I think I could get a more rich level of control over the output by hooking into their parser, albeit with a higher level of complexity.
Comment · 1 year ago
I use `mvdan/sh` [1] under the hood for processing the commands. So it will reformat
if [ foo ] ; then
bar
fi
if [ foo ]
then
bar
fi
foo
bar
Comment · 1 year ago
Is there any reason you prefer `set -e` over `&&`? I'm curious if this is a readability thing.
Comment · 1 year ago
Hi there — I’ll try to distribute a docker release of the binary tomorrow!