mirekm
Joined 6 years ago
Karma
1
Submissions
5
Member since
Mar 27
Code and computers.
View on Hacker NewsRecent submissions
Comment · 5 days ago
Thanks for flagging this. The `.filter(discounted_price_dirty=True)` result was never assigned, so it recalculated every listing.
Fixed here: https://github.com/saleor/saleor/pull/19984 The old test passed for the wrong reason, so we fixed that too.
Bonus: we've also created semgrep rule to prevent unassigned querysets: https://github.com/saleor/saleor/pull/19997
Comment · 7 days ago
Thanks for putting Saleor in. We're going through the voucher ones now, starting with the editor crashes, will fix what's real, and can report back.
Comment · 7 days ago
We're looking into it. Thanks for reporting moon0917!