milkbikis
Joined 14 years ago
Karma
371
Submissions
50
Member since
Jul 8
Recent submissions
Comment · 3 years ago
Coincidentally, I recently looked into the slow startup time for shiki and it was mostly from parsing JSONC, not WASM: https://github.com/shikijs/shiki/issues/439.
Comment · 5 years ago
Ah I didn’t know it was deprecated, but good to see new work happening in this area!
Comment · 5 years ago
Nice, I've always thought Python could do better by adopting source transformation tools like babel. I implemented something similar using lib2to3, which preserves whitespace and comments more accurately (than the ast module): https://github.com/banga/prefactor
Comment · 5 years ago
I wrote https://github.com/banga/git-split-diffs mainly to scratch an itch about not having side by side git diffs in the terminal, then ended up adding more fancy features like syntax highlighting and it got somewhat popular.
Comment · 5 years ago
Yeah I looked into bundling and deno, but neither of those seemed palatable at this point. Deno’s ecosystem is still quite small, so I’d have to implement things like syntax highlighting from scratch which is not feasible. Other bundling options don’t seem all that reliable / popular and they aren’t really solving the actual issue of untrusted dependencies. So my current take is to just use node and be very conservative with dependencies.
Comment · 5 years ago
I actually tried to automate the screenshots for this project's readme using GitHub actions, but struggled to get it to produce the same quality screenshots as my local machine. This is the script I use for now, which has to be invoked manually: https://github.com/banga/git-split-diffs/blob/main/scripts/g...
Comment · 5 years ago
:) thanks nayak!
Comment · 5 years ago
The slowest operation is syntax highlighting: https://github.com/banga/git-split-diffs#performance. I have a PR out to improve that somewhat.
Good point about the themes, I'll add one. I'm hoping to make it easy to customize individual theme colors so you could unset the background colors, for example
Comment · 5 years ago
Yes this is the default behavior for git-split-diffs: https://github.com/banga/git-split-diffs#narrow-terminals
Comment · 5 years ago
Yeah I (un)fortunately learned about delta too late or I probably wouldn't have made this. The main difference is that delta's default styles and appearance did not appeal to me. I'm sure it can be customized, but I wanted something that looked great by default. I especially like that the syntax highlighting matches vscode's since that's the editor I use for work.