makufiru
Joined 11 years ago
Joined 11 years ago
> You have a lot of repetitions of datetime objects that can be stored in a variable. You have a lot of comparisons on the object that can be stored as model properties. Separate them and let these methods breathe please. This looks like callback madness in js. I can't even follow the parenthesis to grasp the flow of conditions here. Even my IDE formatter left me.
Wow. If I saw someone code review like this on my team, they would get one warning. If this behavior was repeated, then they would be fired. There is no place for condescension in the team, even from Senior -> Junior level developers. If anything, this is a great stepping stone for (kindly) teaching a jr. member how to refactor into code that is more readable. Unnecessary jabs like "i pity the poor soul... clearly this isn't the case... looks like JS... even my IDE formatter left me..." and snide hand-wavy remarks like "python is english.. write me some poetry" are only useful to stroke e-peens and push people down publicly.
What would have gone a lot further, in my opinion, was refactoring the code then sending it to the jr. dev and telling them that you refactored their code for them. Tell them that - if they'd like - you'd be happy to walk through the changes and explain why those things were helpful/useful. It's not a contest about who can write the best "poetry". It's about getting along, helping each other, and getting work done.
Jr. devs, if you are reading this, please don't despair. I promise that all teams aren't this bad to work on. There are places where you don't have to be afraid to be the butt of a joke in an HN post and you will actually learn things. If your team is more like the one in the post, you're much better off just leaving for your own sanity.
It seemed somewhere in between C and Python. Really cool.
http://www.ibtimes.co.uk/wikileaks-founder-julian-assange-cl...
Even if it wasn't better, the best language to use on a project is the one you already know. So still Java