k_dumez
Joined 3 years ago
Karma
54
Submissions
15
Member since
Nov 7
Recent submissions
Comment · 2 years ago
Comment · 2 years ago
joined a startup recently whose founding team was entirely from FB (who used Phabricator internally), and Google (who used Critique internally).
They missed those code review tools so much they just rebuilt it themselves lol.
I was initially skeptical but after using it for like 3 or 4 days it's going to be hard to go back to vanilla git tbh
Comment · 2 years ago
BEGONE BOT
Comment · 2 years ago
At my old company Vercel raised our rate by like 40% for enterprise after we had DECREASED usage. It was asinine
Comment · 3 years ago
> When I make changes to a codebase that very few people are experts in and is generally perceived to be difficult to understand,
Not trying to be snarky, genuinely curious, is this a situation you find yourself in very often? Are you describing something while working at a company or in an open-source project?
Comment · 3 years ago
> artificially minimizing PR size
Not sure I understand the "artificial" part here. There's nothing "artificial" about breaking up your larger changes into smaller PRs. It's just good practice.
Helps reviewers who are reviewing the code, and helps the author be more focused with their changes.
Even in net new feature development it's a good idea to break up your large changes to something more manageable.
Sorry if I'm not understanding, what do you believe the downside to be?
Comment · 3 years ago
Sorry, to clarify using "walkable" as a word to encompass good public-transportation as well. I can walk to the subway, and get somewhere 6.2 miles away easily then walk to my final destination (something I do frequently).
Comment · 3 years ago
"In the United States, a staggering 60% of all car trips cover less than 10km."
Being lucky enough to live in a walkable city (NYC) this is insane to me. The world is so car-brained.
Graphite[0] is also similar in that space(code review platform built on GitHub), the CLI could use some work but combined with the web UI it scratches that same itch that Critique did for me
[0] https://graphite.dev/