apaitch
Joined 15 years ago
Joined 15 years ago
If you will, then why not do it before the review and spare everyone the trouble? In a codebase that conforms to certain standards steps away from the standard stick out and distract from the content.
If you won't, then maybe it's good that people point it out so that you can fix it manually?
Of course there is a difference between a comment saying: "Nit: Trailing whitespace" and "According to Section V, Subsection VII of the Coding Manual you should never add trailing whitespace. Please see that you don't." or some stuff like that. The latter is a passive-aggressive potshot, the former IMO is just a quick reminder.
"Self-help books and workshops arm us with ways to trick ourselves into doing things we perhaps should, but generally don’t want, to do."
That seems like quite a generalization. I get that it's hard to create a catchy title without making some form of generalization, but... really? I guess the author is talking about workshops like "How to write and sell your awesome novel in 7 days", but what comes to my mind when hearing "self-improvement" is something like the 7 habits. I hardly saw the latter as an attempt to trick myself into doing things I don't want to do.
With regard to the "giving", I wonder what theories there are about why many people feel good when giving things up to benefit others. Is it just a societal/cultural thing, influenced by religions?
Note: I'm not talking about on-the-job training from someone who doesn't know what a computer is to a master programmer. I'm talking about allowing people who are less immediately capable into the workplace and mentoring/growing them into strong contributors.
Not that it's wrong to evaluate based on that criteria. However, for people like the hypothetical John it's quite hard to keep up with a good CS program and manage to do impressive things on the side. So you end up with people with strong potential, much of it not yet actualized, who spend the first years of their careers in a job of questionable usefulness (excel macros?). I think there are more of those people than commonly assumed, and I do think they can contribute well in much better places. They may be slow at first, but give them 6 months and they will be strong members of the team. Granted, a startup may not have 6 months to give, but once you've got some resources under your belt a green-but-talented engineer can be a great investment.
Hit me up - username at gmail.