andrybak
Joined 3 years ago
Joined 3 years ago
true for some agriculture, but growing the corn for ethanol is stupid
The final singular commit is cc278db (8389219: Implement JEP 401: Value Objects (Preview), 2026-07-31) https://github.com/openjdk/jdk/commit/cc278dbb8a1ca0754d5842...
>
> Summarizing it, 5/7 for delete have accounts, and 1/4 for keep have accounts. Not along after the final vote, a Wikipedia admin deleted the article. Being a little bit lax with my language, the majority's consensus agreed that Odin isn't notable, and the article had no reliable sources.
important clarification about a popular misconception: "Articles for deletion" discussions on English Wikipedia are not decided by vote.
For more details, see
- https://en.wikipedia.org/wiki/Wikipedia:Polling_is_not_a_sub...
- https://en.wikipedia.org/wiki/Wikipedia:Guide_to_deletion#Ov...
- https://en.wikipedia.org/wiki/Circular_reporting#On_Wikipedi...
- https://en.wikipedia.org/wiki/Wikipedia:List_of_citogenesis_...
- previous discussion: https://news.ycombinator.com/item?id=35535407
It's fair that maybe such simple trivial changes don't deserve such a wordy commit message. But these are just fictional examples that I came up with on the spot. Refactorings, new features, and bugfixes can all have various levels of complexity.
A good commit message helps answer the "why?" questions first and foremost. If a diff is fairly large, pointing out the most important change can be useful. Explanations for non-trivial dataflow can sometimes not make sense in separate documentation, but still be relevant in a commit message.
When working in big teams, it can be very hard to increase the usefulness of commit messages. On the other hand, enforcing inclusion of a Jira issue key in commit messages is easy to implement. Relying on issue tracker descriptions can be a difficult proposition as well. Quality of individual ticket descriptions can be low; depending on how responsibility for maintenance is handled, the bug tracker migrations can sometimes be handled improperly and information can be more easily lost than in a Git log.
> Additionally, if a change requires multiple commits, you don't want to be repeating the justifications for the entire feature in every commit message. It's redundant. But the commits will all be tied together by the ticket reference in the commit message.
Different commits do different things, so require different justifications. Here's a fictional example to demonstrate:
First commit:
[PRJ-123] Server: extract class Foo
In the next commit, we're going to need to re-use the foo logic from
class Bar. Extract new class Foo from Bar to make it available for
re-use.
Second commit on the same ticket [PRJ-123] Server: use Foo in Baz
The users of BazClient need to be able to see foo information in the
baz dialog. Include Foo in the data sent by class Baz in the server.
Side note: the user might not even know that they are looking at Foo and Baz, it might be called something else in the UI they are shown. Whether or not this needs to be included in the commit message depends on the situation.And later in a commit fixing a bug:
[PRJ-456] Server: check ID for null in Foo
When class Foo was extracted from Bar in commit deadbeef ([PRJ-123]
Server: extract class Foo, 2026-06-06), a null check for the field
ID got lost by accident.
Check the field ID for null in class Foo to avoid a
NullPointerException when a foo event is sent to Baz.> OH NO I JUST REALIZED THIS IS NOT ACTUALLY PROPERLY FIXED AND STILL WORKS
> even worse, edge no longer even makes the download menu pop up, so it's completely silent js rce that keeps running even after you close the browser !!
> all from just visiting a single website once !!
> issue set to private again, hopefully it'll get fixed properly this time :p
- https://infosec.exchange/@hovav/115731038692335809 - https://mastodon.acm.org/@tadd/115730400064282479