adeebshihadeh
Joined 2 years ago
Joined 2 years ago
1. What’s the goal of this PR and how does it further our project’s goals?
2. Is this vaguely the correct implementation?
Evaluating those two takes a few seconds. Beyond that, yes it takes a while to review and merge even a few line diff.
Not sure about the trust part. Ideally, you can evaluate the change on its own.
In my experience, I immediately know whether I want to close or merge a PR within a few seconds, and the hard part is writing the response to close it such that they don't come back again with the same stuff.
(I review a lot of PRs for openpilot - https://github.com/commaai/openpilot)
glad you're enjoying it :)
never heard of anyone asking for anything like that
happy to answer questions about the four :)
we'll definitely do some good writeups and/or talks once it's shipped.
Our mission is to solve self driving cars while delivering shippable intermediaries. We build and sell the comma 3X to a growing fleet of users and get back 3M minutes of driving data every week for training openpilot.
Some background on what we're hiring for: https://blog.comma.ai/refactoring-for-growth/
- Systems Software Engineer
- Full Stack Software Engineer
- Electronics / Hardware Engineer
- Controls Engineer
- Designer
We're the Android of self-driving cars.
-> Second largest fleet after Tesla, 54% miles engaged
-> Open source, profitable, and lots of cool problems to work on
-> 21 people, mostly engineers: https://blog.comma.ai/refactoring-for-growth
Our hiring process:
* programming challenge or bounty
* quick technical phone call
* paid, on-site micro-internship
Try our programming challenges -- https://comma.ai/leaderboard