Mostly I won't even look at a review until CI passes. I don't want to look at your code if some static analysis in CI would find issues. Once in a while the code is obvious and I won't need that (the one line change "the is not spelled teh" which I've seen multiple times in different areas of code - anyone know of an IDE/tool that can spell check UI strings without tripping up on variable names), but we have a lot of static analysis that we run as part of CI, some of it standard some of it custom for people who violate our code style in some way.
Note that my CI system runs multiple builds in parallel (as yours should too!). Any individual build might only take 10 minutes, but it is 2 hours if I try to run them on my local machine. Odds are if my code builds for one linux variant on x86 it will build on all the other ones and arm so I don't expect someone to run those before starting a review.
Note that my CI system runs multiple builds in parallel (as yours should too!). Any individual build might only take 10 minutes, but it is 2 hours if I try to run them on my local machine. Odds are if my code builds for one linux variant on x86 it will build on all the other ones and arm so I don't expect someone to run those before starting a review.