zeroCalories
Joined 3 years ago
Karma
1,352
Submissions
857
Member since
Nov 29
Joined 3 years ago
1. Give the conclusion first, ramble the details after so people don't get lost.
2. Only share something if it impacts decision making, otherwise it's just noise.
3. Prefer arguments based on facts, because "I don't like it" is too vague for others to make decisions on.
I don't want to update every place someone matches on my enum, when it's something not even in my project, just to get my PR to merge. Three teams use it? Fine. Ten? More? Not fine. You are adding cases into someone else's code just to unblock your own work.
The second case is actually not the same at all. Realistically, they will just pin your dependency to an older version. Now they can't benefit from new features and security fixes without going in and adding in a new case. Massive waste of time for them.
And of course I'm not just taking whatever Google says at face value. I read their justification, and it makes total sense for anyone that works on a non-trivial project. It follows how any stable public API is supposed to be designed.