oskarsv
Joined 6 years ago
Joined 6 years ago
(it’s more than 30MB of compressed JS)
There is little value in going through the email chains to note each date:(. Final decision was made 2020-11-19
I can’t call this “spoofing” as there are many many things you can do wih it
But if not addressed to me, there is no need to pay, you can start here: - https://www.electronjs.org/docs/tutorial/security - https://github.com/electron/electron/security/advisories
As you can see there are plenty of considerations and pitfalls to take into account. Best option is to enable contextIsolation for everything.
Further, Electron security is closely tied to Chrome security so that is one deep rabbit hole
I mean, do you look at that demo and think "yeah, that's technically just 'important' let's fix it in 2 months"?
not saying you are safe - I don’t know :)
the real answer is more complicated as it is not necessarily a global setting and depends on what you call a “sandbox”
I think it will take a long time before we can call ElectronJS secure. there are regular sandbox escapes and that is from what we know publicly
As for when it was fixed - I have no idea, as they never told me, one day it just was.
Even outside RCE, just consider the impact of access to SSO tokens and wormability :)
In this case it was possible to abuse lack of context isolation to overwrite functionality (first part of the JS exploit). This changed function behaviour to return (leak) a BrowserWindow class (https://www.electronjs.org/docs/api/browser-window) when calling window.open(). A BrowserWindow class allows to instantiate a new window with your own security settings :)
Some of the current non-standard functions in Slack: https://imgur.com/a/OSjS0kJ
More info: https://www.electronjs.org/docs/tutorial/security
In other cases maybe yes, maybe no - for some nonprofit, maybe someone needs help? are they a business and can they afford to compensate this kind of work? maybe it is some prominent product? there is no simple answer
No, I do agree - from my perspective C/C++ class bugs are more difficult. Maybe they see this as magic as well.
Still, it was painstaking work and in either case CountryX will easily surpass those difficulties.