deadbeef404
Joined 13 years ago
Joined 13 years ago
Array.from(document.getElementsByClassName('comment')).forEach(x => {if (/Trump/.test(x.innerText)) { x.innerText = 'Trumped' }})
> Have you used CharmPy?
> You mean PyCharm?
> No, CharmPy!
> Are we talking about the same thing?
> No
> Oh, that's just confusing, then.
Once again though, nice work! :)
In regards to: > if you use JS libs they won't follow PEP 8 either. > And that's probably something to accept, as, however > big the Python world, one cannot ignore the JS world.
I totally agree. I spend about half of my time writing JS and half in Python and I definitely don't try to enforce PEP8 guidelines onto JS code, simply because it's a Python style guide, not a JS guide. I would try to follow a largely accepted code style of the JS community if I was made aware of one, but there only seems to be a large collection of non-official guides, so just I try to adjust my code style to what seems to be common among all of the "nice"/readable code around the web, or, if I'm working in a large existing code base, the style that is followed in that codebase, unless there's reason good not to.
I guess my general approach is that I prefer to style the code I write based upon the language (sometimes, for example, this requires placing open braces in different positions), and I find this actually helps my mind to switch between languages as they have their own look-and-feel to them.
Thanks for reading, and thanks for writing a very interesting library!
As a side note: I found your extra whitespace before function arguments to be very strange. I haven't seen this type of spacing before. Is there a reason why you do this?
I personally use and encourage the use of the "pep8" python tool (link below) to validate my codestyle as I find it makes working with other developers easier (this extra whitespace is pointed out as an error).
pep8 tool: https://pypi.python.org/pypi/pep8
http://www.pcmag.com/article2/0,2817,2458699,00.asp
Also, just for clarification, do you mean self-repairable? The review said it, like the MBP, has non-standard screw heads making repair difficult. Thoughts?