aredplug
Joined 4 years ago
Karma
47
Submissions
10
Member since
Dec 17
Joined 4 years ago
If people choose to ignore comments, then that's a behavioral issue worth escalating.
... applies to code reviewers.
I like Google's review standard:
"In general, reviewers should favor approving a [PR] once it is in a state where it definitely improves the overall code health of the system being worked on, even if the [PR] isn’t perfect."
https://google.github.io/eng-practices/review/reviewer/stand...
I had back pain for a few years. After physio and other improvements I tried an Ergodox and that didn't fix it.
Perhaps you're overly cynical?
Either way, a good demonstration of the value of empirical evidence.
Keep up the good work!