5Qn8mNbc2FNCiVV
Joined 7 years ago
Joined 7 years ago
https://github.com/zed-industries/zed/issues/26560#issuecomm...
Obviously this is a rare thing to do, but from reading the other comments it's miles better than being bullied out, quitting and letting the other person continue with that attitude
If the PR went in a completely different direction and missed the goal by a lot, I take ownership of it (with a brief explanation) and re-implement it. I then use the new PR for a pairing session, where I walk through both PRs with the original author for learning purposes.
If it’s mostly smaller issues, I schedule a half-hour pairing session with the author and review everything together, after preparing a list of issues.
Doing it any other way puts too much burden on the author to guess what the reviewer wants, and it slows down velocity significantly.
As long as you make it clear from your tone and wording, that this is not you being aggressive in any way but you protecting the time of the team from distractions, the rest of the team shouldn't see you any different than before.
This is a step forward, but what's the way forward?
I've got pretty sizeable codebases, less than 5 useEffects ever (nowadays I only have one for a single location where I need to manually poll, the rest is useSyncExternalStore) and I only do useMemo for tables.
Compiler is just an additional performance improvement that's "free" and at least the compiler doesn't make it harder to understand how your code executes because it just works
Not saying better-auth is strictly better, but at least you can read the docs and know what you're getting into yourself instead of 12 variations of the same thing