Comment

Comment by remi

Instead of using a service like this one (or Hound) that comments directly on pull requests, we chose to integrate the same tools in our build process with Phare (https://github.com/mirego/phare), a command-line tool we built which runs Rubocop, JSHint, JSCS, etc. and exits with a global status.

If the code has coding style violations, the build breaks. Exactly like it would if we pushed a failing test.

Personally, I’m not a fan of the noise generated by comments about coding style on pull requests.

parent remi 11 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton