Comment

Comment by afternooner

It could be a bad sign, or it could speak to priorities, and your priorities are not their priorities it seems. Personally, I accept all pull requests that are solid, written to my standards, fix or extend a feature that is a priority, are accompanied with unit tests, and do not impact or impinge on another feature or future feature. I do not however accept all pull requests. Part of this is that if there is no demand and it's a single individuals edge case, then I'll very heavily scrutinize the patch. If I don't agree, don't understand exactly what every line is doing, or do not feel it will be used by a significant portion of the user base then I won't pull it. Because moving forward, I will have to maintain it, and that isn't free. And if people don't like that, they can fork it.
parent afternooner 12 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton