My late father was a child during the depression era and so he grew up to be very resourceful/thrifty, hard working, and epitomized the "waste not, want not" slogan. So yes it can come off as hoarding and it was a lot to go through after he passed. Yet after a lifetime of scrimping, saving, reusing, and repurposing, he ended up with quite a lot to show for it. He never paid for storage, didn't clutter any open spaces, but every closet or spare room of his home was packed.
If you have the storage then by all means keep whatever you value. If it would require paying a recurring fee to keep it, then it better be worth it.
If you have the storage then by all means keep whatever you value. If it would require paying a recurring fee to keep it, then it better be worth it.