The fundamental problem in music notation is that it was designed for an 8 note system and we use a 12 note system. It's.. fine I guess, they got those extra four notes in there and millions of people read music with no problems. But it does create a lot of confusion for novice readers who now think those 8 notes are somehow more important than the other 4 or that the sharps and flats are somehow half notes(they are not, all 12 are equally spaced on a log scale) and don't even get me started on the confusing terminology, there are 12 notes in an octet, semitones? a fifth? a fifth of what? it is seven notes or 3/2's there is no 5.
With regard to the piano keyboard, again not terrible, but it definitely is a compromise to fit the mechanical needs of the piano. I really like the design of the chromatic keyboard(ever see an accordion with the big hex grid of buttons, this is a chromatic keyboard), it has the advantage that whatever key you play a song in it has the same fingering, on a piano every key has different fingering, so there is a big skill barrier to changing keys that interferes with employment of such a critical aspect of playing.
With regard to the piano keyboard, again not terrible, but it definitely is a compromise to fit the mechanical needs of the piano. I really like the design of the chromatic keyboard(ever see an accordion with the big hex grid of buttons, this is a chromatic keyboard), it has the advantage that whatever key you play a song in it has the same fingering, on a piano every key has different fingering, so there is a big skill barrier to changing keys that interferes with employment of such a critical aspect of playing.