Comment Comment by GodelNumbering Was just looking at commits and came across a commit and its revertoriginal commit: https://github.com/RsyncProject/rsync/commit/d046525de39315d...```- if (!ptr)- ptr = malloc(num * size);- else if (ptr == do_calloc)+ if (!ptr || ptr == do_calloc) ptr = calloc(num, size); ```Written with claude. This is a good example of what slips through LLM attention. It forces all allocations to be calloc as if it is a strict upgrade. For large and recursive allocations, this becomes a significant cost.reverted in https://github.com/RsyncProject/rsync/commit/7db73ad9a1b8721...if you read the description of revert half carefully, it's easy to tell that even that was written by an LLM .I can understand the sentiment of whoever posted the original thread. parent GodelNumbering 5 months ago
original commit: https://github.com/RsyncProject/rsync/commit/d046525de39315d...
```
- if (!ptr)
- ptr = malloc(num * size);
- else if (ptr == do_calloc)
+ if (!ptr || ptr == do_calloc)
```Written with claude. This is a good example of what slips through LLM attention. It forces all allocations to be calloc as if it is a strict upgrade. For large and recursive allocations, this becomes a significant cost.
reverted in https://github.com/RsyncProject/rsync/commit/7db73ad9a1b8721...
if you read the description of revert half carefully, it's easy to tell that even that was written by an LLM .
I can understand the sentiment of whoever posted the original thread.