Comment Comment by ceteia Nitpicking:https://github.com/thelowsunoverthemoon/mahler.c/blob/4ebfe8...Should that type have been mah_acci instead of int? mah_acci doesn't seem to be used anywhere.Also, have you considered using (edit) designated initializer syntax for some of the function calls that take in structs as arguments?https://cppreference.com/w/c/language/struct_initialization.... struct mah_scale scale = mah_get_scale( (struct mah_note) { .tone=MAH_C, .acci=MAH_NATURAL, .pitch=4 }, &MAH_BLUES_SCALE, notes, MAH_ASCEND, NULL ); parent ceteia 8 months ago
https://github.com/thelowsunoverthemoon/mahler.c/blob/4ebfe8...
Should that type have been mah_acci instead of int? mah_acci doesn't seem to be used anywhere.
Also, have you considered using (edit) designated initializer syntax for some of the function calls that take in structs as arguments?
https://cppreference.com/w/c/language/struct_initialization....