Comment

Comment by rkallos

> I look at the reddest part of the chart, I look at the peaks

Neither of these are really the places I look at when examining flame graphs. I tend to look at the bottom, and work my way up.

The key thing (imo) to look for are wide pieces that are not a core part of what the code you're profiling is supposed to do.

In the first example of your first link, you have a flame graph of code that seems to draw an image. There are a bunch of functions like 'CopyPixels' and 'RasterizeEdges'. Those seem to be a core part of drawing an image. In contrast, there's a 'KiPageFault' function that's pretty wide that does not seem to be important to the code's overall goal. I think a bit more context is needed to arrive at the author's conclusion, though.

I think flame graphs, like all graphs, are more helpful when the reader has a lot of context about what's supposed to happen, or some intuition about how the chart is supposed to look.

parent rkallos 2 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton