Comment

Comment by palata

Not the OP, but I think that the point of squashing every PR is that the reviewers/PR run the whole PR, not the individual commits. If you have a PR with 5 commits, 4 of which break the build and the last one fixes it, then merging that will be a problem if you need to git bisect later.

So the idea is really "what's the point of having a history full of broken state?".

> It must be impossible to understand commits' diffs with the changes all squashed together.

This would be a hint that your PR was too big and addressing more than one thing.

parent palata 2 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton