Comment

Comment by cantSpellSober

MUCH more legible and responsive than the existing site, thank you

1. Why not just write a CSS skin for the existing site? The <table> layout?

2. Tap targets are much improved (good luck tapping up vs down arrows on the existing site on your first try)

3. Upvote/downvote icons being on the left side is a pretty well established pattern, why move to the right?

4. Type hierarchy is ok, a little too much whitespace, the titles could be bigger (still much better than existing)

5. White text on bright orange is hard to read

6. Looks like you're using JS/CSS libraries (Tailwind, Radix), only 10% of it is applied but the entire library is loaded (file is huge), a preprocessor can fix that

7. I'd consider adding infinite scroll

8. Buttons top-left have `default` as the `cursor` value, you want `pointer`

9. Those buttons' aria attrs are insane, are they valid?

10. Put hover/active states on the links

11. Are the icons on the left going to be thumbnails? Don't see the point of these

12. You absolutely MUST add a footer (lol jk)

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton