Comment

Comment by mariojv

I liked Gerrit when working on OpenStack several years ago. The use of patch sets seemed pretty intuitive, and it was nice that there wasn't a "force push" workflow available that would hide changes from previous reviews. I tend to use a merge rather than rebase workflow with GitHub now, but I often see developers do the opposite, which can make directly viewing code changes from previous reviews challenging.

I am surprised that this post advocates for amending commits, though. It's been a while, so I might be misremembering, but I think a tool like git review makes that unnecessary:

https://www.mediawiki.org/wiki/Gerrit/git-review

https://docs.opendev.org/opendev/git-review/latest/

parent mariojv 2 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton