Comment Comment by iot_devs This is an huge issue for us in a very big and complex codebase with a lot of engineers working on it.Code review is hard because the diff always looks reasonable, the tests always pass and all the basic stuff are always checked.However, it happens often that, even if the changes looks reasonable they are wrong.The whole architecture may drift after one bad change that looks reasonable.As always this is not strictly a problem with the tooling, but more of culture and knowledge sharing.And we are not going to solve it with a better tool. parent iot_devs 3 years ago
Code review is hard because the diff always looks reasonable, the tests always pass and all the basic stuff are always checked.
However, it happens often that, even if the changes looks reasonable they are wrong.
The whole architecture may drift after one bad change that looks reasonable.
As always this is not strictly a problem with the tooling, but more of culture and knowledge sharing.
And we are not going to solve it with a better tool.