Comment

Comment by drodgers

This is not confidence inspiring. These fixes are only surface-level, rather than looking at the underlying systemic failures:

- Not storing key data in an HSM.

- Exporting crashdumps outside of the production account.

Redacting private keys and other sensitive data from these will always be failure-prone. Keys are also only just one problem, there will be personal data, passwords etc. in those dumps depending on what process it was.

- Corp environment infiltration not detected at the time (presumably, since this part is pure guesswork)

- Not enough log retention in the corp environment to track a 2 year old infiltration.

- Not assuring that key validation correctly denied requests with the wrong scope.

Fails-with-a-valid-key-with-wrong-(scope/date/subject etc.) are the kind of cases that always deserve test coverage, especially for a dedicated key-validation endpoint. Also concerning that this wasn't found by manual-testing/red-teaming/pen-testing in the time since it shipped.

- Slow detection, slow response, poor communication

parent drodgers 3 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton