Comment

Comment by bri3d

I understand that you're probably trying to get Reddit upvotes as well, but I think a link to the repo itself [0] would be better.

And a little critique about your code: you shouldn't set the ivar backing synthesized properties in your implementation (instance) methods. For example, in RDBrowserController.m doing

    self.webView = wv
(invoking the setter) rather than

    if (webView) [webView release];
    webView = wv;  
is both shorter and universally safer, and prevents issues if you end up using Key-Value Observing down the road.

It's also safer to retain the new value before releasing the current value in setters you write yourself - this prevents setting to the same value repeatedly from releasing the object prior to retaining it.

0: https://github.com/samuraisam/readdit

parent bri3d 14 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton