Don't get me wrong, it's not "bad" code (from a brief glance) but it's just clearly written as if it was Java code, and probably not in a usual IDE like Visual Studio, Rider or VSCode /w C# plugin (as that would typically scaffold a more C#-esque style).
Here's what I've noticed so far:
- Uses camelCase instead of PascalCase
- Uses setter and getter methods instead of C# properties.
- Uses reverse DNS namespace com.mc2k.SimCityReader instead of e.g. JGosar.MineCity2000.SimCityReader.
- Lack of LINQ (It is such a big part of C#, that not using it at all is strange).*
- Lac of using generics e.g. List<string> instead of string[].*
- Excessive use of arrays (you'd typically use a simple IEnumerable<T> or List<T>).
- Lack of `var`.*
- Casting integer literals to short, byte, etc -- these all have equivalent literal notation.*
- Lack of extension methods.*
- Lack of maps (pattern matching).*
There could be more, but those are what I noticed.
EDIT: * Given that the original code was done with VS 2010 and .NET Framework 4, its fair to say that a few of the points above do not apply, but the code is nevertheless very java-esque (just from the first two points).
Here's what I've noticed so far:
- Uses camelCase instead of PascalCase
- Uses setter and getter methods instead of C# properties.
- Uses reverse DNS namespace com.mc2k.SimCityReader instead of e.g. JGosar.MineCity2000.SimCityReader.
- Lack of LINQ (It is such a big part of C#, that not using it at all is strange).*
- Lac of using generics e.g. List<string> instead of string[].*
- Excessive use of arrays (you'd typically use a simple IEnumerable<T> or List<T>).
- Lack of `var`.*
- Casting integer literals to short, byte, etc -- these all have equivalent literal notation.*
- Lack of extension methods.*
- Lack of maps (pattern matching).*
There could be more, but those are what I noticed.
EDIT: * Given that the original code was done with VS 2010 and .NET Framework 4, its fair to say that a few of the points above do not apply, but the code is nevertheless very java-esque (just from the first two points).