Comment

Comment by jamie_ca

> Merged a pull request without a review - 100% toxic.

There's a case where this is not just ok, but healthy (especially on smaller teams) - if you're comfortable doing trunk-based development then you can use a PR to "snapshot" a set of changes and either invite commentary or just have a link to share as an FYI around the change, without the awkwardness of linking to an unnamed commit sequence.

https://martinfowler.com/articles/ship-show-ask.html

parent jamie_ca 4 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton