Rules I would have everyone follow if I was a dictator:
1. 1 PR, 1 commit.
2. 1 PR cannot have more than 50 lines of product code added. Any number of lines can be removed. You can have up to 100 lines of test code.
3. Every PR should include a set of tests for the added/changed functionality. They must pass.
4. Git merge is forbidden. Everyone must rebase.
5. Every PR goes into master. Nobody can push to master. You can create as many feature branches you like, but definition of done is that your code is available on master.
6. Identify relevant existing test cases and make sure they are passing.
7. Master must always be in a state that it can be deployed instantly.
1. 1 PR, 1 commit.
2. 1 PR cannot have more than 50 lines of product code added. Any number of lines can be removed. You can have up to 100 lines of test code.
3. Every PR should include a set of tests for the added/changed functionality. They must pass.
4. Git merge is forbidden. Everyone must rebase.
5. Every PR goes into master. Nobody can push to master. You can create as many feature branches you like, but definition of done is that your code is available on master.
6. Identify relevant existing test cases and make sure they are passing.
7. Master must always be in a state that it can be deployed instantly.