Perhaps, silence would be a good choice on this issue?
To my view, coding is as much art as science, and it is limitlessly fascinating to me how different people find different ways of expressing ideas and solutions.
Also, the code review process is fraught with opportunities for insult, misunderstanding and unfortunate power dynamics. It is inherently difficult regardless of the actual content being reviewed.
On the other hand, if there is a significant issue here "I am having trouble following your thinking here. Perhaps dividing this up into smaller functions would help?" Might be a good review comment?
The style wars are very tempting to engage in, but they virtually never drive greater productivity, real quality improvements, or positive team dynamics.
If there are real reasons that this wants to be broken out into a separate function (reusability for instance), then make that clear in your suggestion.
To my view, coding is as much art as science, and it is limitlessly fascinating to me how different people find different ways of expressing ideas and solutions.
Also, the code review process is fraught with opportunities for insult, misunderstanding and unfortunate power dynamics. It is inherently difficult regardless of the actual content being reviewed.
On the other hand, if there is a significant issue here "I am having trouble following your thinking here. Perhaps dividing this up into smaller functions would help?" Might be a good review comment?
The style wars are very tempting to engage in, but they virtually never drive greater productivity, real quality improvements, or positive team dynamics.
If there are real reasons that this wants to be broken out into a separate function (reusability for instance), then make that clear in your suggestion.