Comment

Comment by LittlePeter

Whatever test runs during pre-commit must also run during normal CI/CD run. In case of Python: black formatter.

It must run during normal CI/CD because pre-commit hooks can be skipped.

So now I have two different black calls: in the pre-commit hook and in the CI/CD. And they must be of the same version.

Ad infinitum for all other tests.

This is the reason I don't use pre-commit framework. It leads to "double accounting". I have to sync the pre-commit tests and the CI/CD tests. Or am I missing something? Can the framework run off the venv dir?

parent LittlePeter 4 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton