To add balance to the statement about asking an art student to give an opinion of your work to get your ego stroked, I had a far different experience. I went to art school, and from foundation year (where you learn a smattering of everything: drawing, painting, sculpting, etc.) to senior year (when I focused on film and animation) I constantly had my work reviewed. Sometimes I got effusive praise, and sometimes I left class devastated. Usually, the feedback was right-on, usually honest, and usually came from a good place. Learning how to express criticism of another's work, and learning how to accept constructive criticism of my own, was one of the most valuable skills I learned from school.
To make this germane to hacking: I'm kind of baffled that peer code review isn't the cornerstone of this industry. No one works best in a bubble, and everyone has something to teach and to learn.
One last thought -- context for feedback matters. It's a helpful, kind, human thing to do to give someone some helpful encouragement, even when it hasn't been earned yet.
To make this germane to hacking: I'm kind of baffled that peer code review isn't the cornerstone of this industry. No one works best in a bubble, and everyone has something to teach and to learn.
One last thought -- context for feedback matters. It's a helpful, kind, human thing to do to give someone some helpful encouragement, even when it hasn't been earned yet.