Comment Comment by uasm > "I would recommend musl, although the style is a bit idiosyncratic in places: https://www.musl-libc.org"Opened a random part of musl out of sheer boredom. Here's what I see:https://git.musl-libc.org/cgit/musl/tree/include/aio.hA bunch of return codes #defined like so (see https://git.musl-libc.org/cgit/musl/tree/src/aio/aio.c):#define AIO_CANCELED 0 #define AIO_NOTCANCELED 1 #define AIO_ALLDONE 2#define LIO_READ 0 #define LIO_WRITE 1 #define LIO_NOP 2#define LIO_WAIT 0 #define LIO_NOWAIT 1Why weren't they using an enum instead? I wouldn't sign off on this code (and I don't think it lives up to best practices). parent uasm 6 years ago
Opened a random part of musl out of sheer boredom. Here's what I see:
https://git.musl-libc.org/cgit/musl/tree/include/aio.h
A bunch of return codes #defined like so (see https://git.musl-libc.org/cgit/musl/tree/src/aio/aio.c):
#define AIO_CANCELED 0 #define AIO_NOTCANCELED 1 #define AIO_ALLDONE 2
#define LIO_READ 0 #define LIO_WRITE 1 #define LIO_NOP 2
#define LIO_WAIT 0 #define LIO_NOWAIT 1
Why weren't they using an enum instead? I wouldn't sign off on this code (and I don't think it lives up to best practices).