Comment

Comment by swish_bob

I'm stunned by the number of people who think that reviewing a PR is just a matter of checking the code works and looks clean.

Does nobody ask what the code is for and why you're doing it? I mean, I don't expect people to require detailed specs before approving, but a quick "what's this code for, and why are you doing it?" before addressing the details.

Surely that's the bare minimum, isn't it?

parent swish_bob 6 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton