I follow several public and private projects that I do not contribute at all. Any time there is a review comment on a pull request from senior devs, I try to check if it is new to me. If so, I note down the problem and suggestions.
Here are some examples:
- Aleks suggested to limit the try to the places where exceptions can be thrown and move everything else out of the try.
- Thomas suggested to use =StringBuilder= instead of =String.format=. The former is faster and more robust.
- Oscar suggested to use a =parameter object= or a =builder= when there are many (more than 3-4) parameters.
I follow several public and private projects that I do not contribute at all. Any time there is a review comment on a pull request from senior devs, I try to check if it is new to me. If so, I note down the problem and suggestions.
Here are some examples:
- Aleks suggested to limit the try to the places where exceptions can be thrown and move everything else out of the try.
- Thomas suggested to use =StringBuilder= instead of =String.format=. The former is faster and more robust.
- Oscar suggested to use a =parameter object= or a =builder= when there are many (more than 3-4) parameters.