I don't know Stellar, but I am interested in crypto and blockchain technology.
You say you are working with the Stellar blockchain. But then you say it's a thin wrapper around an API.
Are you doing the crypto (creating private keys, signing transactions) in your code? Looking through the code it looks like you call something called 'stellar-sdk' for it. Which is not part of the repo. I have the feeling the magic is happening in this external code. Which conflicts with the statement that the wallet is "easy to understand at a glance and transparent enough to be easily customized and fully trusted". One would have to also analyze that stellar-sdk: https://github.com/stellar/js-stellar-sdk/tree/master/src
Something that is way too big to understand easily.
Also, I see some account creation code in your repo. If it is using a blockchain, why is it creating accounts on a service via an API? Can't I have my Stellar assets under control without having an account somewhere?
You say you are working with the Stellar blockchain. But then you say it's a thin wrapper around an API.
Are you doing the crypto (creating private keys, signing transactions) in your code? Looking through the code it looks like you call something called 'stellar-sdk' for it. Which is not part of the repo. I have the feeling the magic is happening in this external code. Which conflicts with the statement that the wallet is "easy to understand at a glance and transparent enough to be easily customized and fully trusted". One would have to also analyze that stellar-sdk: https://github.com/stellar/js-stellar-sdk/tree/master/src Something that is way too big to understand easily.
Also, I see some account creation code in your repo. If it is using a blockchain, why is it creating accounts on a service via an API? Can't I have my Stellar assets under control without having an account somewhere?