Discussion

Ask HN: How you approach addressing PR comments in Open Source projects

Hello,

I have been a bit active recently on a Chrome extension repo that I found very useful with PRs and enhancements suggestions. However, sometimes I felt that the comments are very opinionated by the maintainers and at some point made me just stop trying to "contribute" and just maintain my fork. I am wondering if there are any best practices in dealing with OS collaboration.

On a similar note, I want to ask how people usually approach addressing PR comments. For example, for one PR I had over 10 comments and the Github page was flooded with comments that I wanted to address. It was crazy at some point to keep track of them as I dont want to push every commit for every fix I did so that I can see the `outdated` collapsable code block that Github shows. I have came up with this idea https://github.com/sindresorhus/refined-github/pull/1407 which allows you to have a task-list like feature on the PR comments.

Would love your thoughts on this.

Thanks

3 points ahmadassaf 8 years ago 1 comments

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton