Comment Comment by brianvaughn > In your experience, what are the kind of things that people do in `componentWillMount` that they shouldn't be doing?The biggest one is probably adding event listeners or setting up subscriptions (which can cause memory leaks).Here are some others: https://github.com/reactjs/rfcs/blob/master/text/0006-static...> Is it correct to say that `getSnapshotBeforeUpdate` is named to indicate what you were supposed to use `componentWillMount` for?No. `getSnapshotBeforeUpdate` is not really related to `componentWillMount`. It relates more to what people were using `componentWillUpdate` for. parent brianvaughn 8 years ago
The biggest one is probably adding event listeners or setting up subscriptions (which can cause memory leaks).
Here are some others: https://github.com/reactjs/rfcs/blob/master/text/0006-static...
> Is it correct to say that `getSnapshotBeforeUpdate` is named to indicate what you were supposed to use `componentWillMount` for?
No. `getSnapshotBeforeUpdate` is not really related to `componentWillMount`. It relates more to what people were using `componentWillUpdate` for.