Comment

Comment by IncRnd

  if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
      goto fail;
      goto fail;  /* MISTAKE! THIS LINE SHOULD NOT BE HERE */
  if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
      goto fail;

History repeats itself in ever stranger ways. While the effects are different, the original mistake can be quite similar.

parent IncRnd 9 years ago

Comment by IncRnd

Discussion