Comment

Comment by johannes1234321

From a short review I don't like this much.

- It's containing it's own abstraction over pthread instead of std::thread/std::mutex/... - It passes shared_ptr via reference (yeah, this saves an increment and decrement on the refcounting, but the code is not tuned that much) - it prints directly to sterr (via fprintf) making it hard to redirect errors somewhere else - It seems not to be prepared to be ported to other platforms - It could make use of std::chrono instead of int64 timestamps - no build system (no CMake or anything) - tests not integrated, look verbose, all tests individually recompile all files, makes it hard to work test-drive

In summary I see no compelling reason over boost asio or such and potential issues.

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton