Comment

Comment by Merovius

What worries me about this is performance. Contexts are linked lists and adding a new value to log will add a new node to this list, slowing down all future operations involving the context. I didn't look at the implementation, but I, at least, couldn't come up with a design that doesn't suffer from this, when I last thought about it. What makes matters worse is, that the logging layer is wrapped around the context in a pretty early stack frame; so every logging statement will need to traverse the whole context list, slowing down the overhead from logging even further than it already is.

So, did you look into this? Does Performance suffer?

parent Merovius 10 years ago

Discussion

Live from the official Hacker News API

A modern reader for Hacker News · SvelteKit + Skeleton